Fix stack overflow in case of loops in the graph#88
Open
stefanhahmann wants to merge 1 commit into
Open
Conversation
In case of loops in the graph, more precisely, in the situation, when the last spot of a branch has an outgoing edge to itself, label spots systematically got to a stack overflow situation due to a recursion that does not finish. This commit adds conditions to leave the recursion and extends the unit test to proof, the fix is working
Collaborator
Author
|
@maarzt just a reminder to have a look on this so that it can maybe be merged soon-ish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of loops in the graph, more precisely, in the situation, when the last spot of a branch has an outgoing edge to itself, label spots systematically got to a stack overflow situation due to a recursion that does not finish. This PR adds conditions to leave the recursion and extends the unit test to proof, the fix is working.
Fixes #86 with the more robust implementation of the algorithm, but not with the more laborious plugin to the tests for problems in the graph and offers to fix them automatically